-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With sync update, get revision name with latestReadyRevisionName #505
Conversation
- We got synchronous service update operation, ensuring the requested config change is reconciled before service update operation returns. knative#271 - Traffic splitting e2e tests, do sync service update to generate the revisions. - With every service update, we need to grab the revision name generated with this update (for subsequent operations), which we can grab using `latestReadyRevisionName` since sync service updated returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navidshaikh: 0 warnings.
In response to this:
/lint
Fixes #500
Proposed Changes
We got synchronous service update operation, ensuring the requested
config change is reconciled before service update operation returns. feature(service): Wait on update for service to become ready. #271Traffic splitting e2e tests, do sync service update to generate the
revisions.With every service update, we need to grab the revision
name generated with this update (for subsequent operations),
which we can grab usinglatestReadyRevisionName
since sync service updated returned.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per #500 e2e for a test, actual result:
The service update returned successfully, means the requested changes were reconciled, then The failure though reports,
which means that, service didn't put correct revisionName for |
We can update the traffic splitting tests to reference BYO revision names using |
/test pull-knative-client-integration-tests-latest-release |
From the first CI run against serving nightly (
The steps before the failed operation were: 2 - Sync 3 - 4 - Sync 5 - At this point, we expect |
- for traffic splitting e2e tests - Check the comment on knative#500 (comment)
@navidshaikh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Beside pausing for 3 seconds to let |
The needed changes are addressed in #506 |
@navidshaikh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This complicates somewhat the teardown process, especially that test logger can no longer be valid (`t` might be destroyed already, causing a panic). This logging seems not to contribute much anyway. Also did a pass over the file and cleaned some stuff here and there. Once commited, I'll cleanup serving where it's used.
* [SRVCLI-250] Sync e2e scripts from master * fix: Fix branch names
/lint
Fixes # 500Check #506Proposed Changes
We got synchronous service update operation, ensuring the requested
config change is reconciled before service update operation returns. feature(service): Wait on update for service to become ready. #271
Traffic splitting e2e tests, do sync service update to generate the
revisions.
With every service update, we need to grab the revision
name generated with this update (for subsequent operations),
which we can grab using
latestReadyRevisionName
since sync service updated returned.